Replace tempdir with tempfile #176
Conversation
|
So this problem seem to be that a sub-dependency of tempdir (that have MSRV 1.63) seem to have a MSRV of 1.65. As far as I know that isn't really solvable without hand editing a Cargo.lock file, and that seems a bit extreme. If anyone have a suggesion on how to solve this I'm happy to try it out :) |
|
The 1.63 test jobs can be switched to check-only, so our dev dependencies aren't limited by the MSRV. |
|
I'm not an expert at build jobs, should I delete this line: https://github.com/rust-lang/glob/blob/master/.github/workflows/rust.yml#L23 since the MSRV build check is done here: https://github.com/rust-lang/glob/blob/master/.github/workflows/rust.yml#L71 ? |
|
Rather than deleting the first line, just bump it to whatever the MSRV for tempdir / its deps is. No harm in keeping a reasonably old test here, even though we have the MSRV check. (Would be nice if the MSRV check covered multiple platforms, but that can happen separately) |
alexanderkjall
force-pushed
the
replace-tempdir-with-tempfile
branch
from
964a9bc to
f70cbe9
Compare
alexanderkjall
force-pushed
the
replace-tempdir-with-tempfile
branch
from
f70cbe9 to
f2be6c3
Compare
|
Done, I had to dump it all the way up to .71 due to a windows-only dep. Thanks for the guidance. |
2 participants
as the tempdir crate has been superseded by tempfile.
Now that MSRV was raised in #172 we can replace tempdir with tempfile.