Skip to content

Conversation

JustForFun88
Copy link
Contributor

The guard.0 = index + 1 in the implementation of clone_from _impl is completely unnecessary, since an invalid index can be set in advance.

@Amanieu
Copy link
Member

Amanieu commented Apr 16, 2024

The + 1 is implicitly calculated by the iterator anyways, so it doesn't cost anything extra in optimized builds.

I prefer the original form of the code since guard.0 clearly indicates the point that separates the initialized part of the array vs the uninitialized part. This also avoids the need to special-case usize::MAX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants