Skip to content

Remove mach-related items #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2024
Merged

Remove mach-related items #3533

merged 1 commit into from
Jan 28, 2024

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jan 10, 2024 •
edited
Loading

...as we recommend using mach2 instead.

@rustbot
Copy link
Collaborator

rustbot commented Jan 10, 2024

@JohnTitor: no appropriate reviewer found, use r? to override

@JohnTitor JohnTitor force-pushed the rm-mach branch 2 times, most recently from 6f86ca0 to e425743 Compare January 28, 2024 09:10
@JohnTitor JohnTitor enabled auto-merge January 28, 2024 09:15
@JohnTitor JohnTitor added this pull request to the merge queue Jan 28, 2024
Merged via the queue into rust-lang:main with commit fd01d57 Jan 28, 2024
@JohnTitor JohnTitor deleted the rm-mach branch January 28, 2024 14:31
@tgross35 tgross35 added this to the 1.0 milestone Aug 16, 2024
@bdash
Copy link

bdash commented Oct 6, 2024

I'm confused as to why structures related to the Mach-O file format are being removed. They're not part of the Mach kernel APIs. mach2 does not provide these types, AFAICT, and it claims to provide /usr/include/mach, not /usr/include/mach-o.

mach_header / mach_header_64 are part of the definition of the Mach-O file format. A random subset of other Mach-O structures still remain: segment_command, load_command, and related constants such as MH_MAGIC and LC_SEGMENT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

breakage-candidate S-waiting-on-review

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JohnTitor @rustbot @bdash @tgross35