-
Notifications
You must be signed in to change notification settings - Fork 1.1k
freebsd15: Add ki_uerrmsg to struct kinfo_proc #4553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@asomers given this does technically break the struct definition, do you want this on stable? I think if this is done, the struct should be marked The change itself LGTM |
This change only affects FreeBSD 15. That release is still under development, and therefore no backwards-compatibility concerns apply. So yes I think we should merge it to libc-0.2. |
Thanks for confirming, that's perfect. I think we should still add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you just make the struct #[non_exhaustive]
? We're starting to do this for everything new, may as well do it with the change here as well
228246f
to
b8d9379
Compare
struct kinfo_proc may be extended again in the future. Add #[non_exhaustive] to let the compiler and other tooling know.
b8d9379
to
65331f2
Compare
commit added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description
During the development of FreeBSD 15, a field was added to
kinfo_proc
. With this PR and #4552, thelibc-test
suite passes on FreeBSD 15 on ppc64.Sources
Upstream commit: freebsd/freebsd-src@7212b37
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI