libc-test: port windows to use ctest-next #4600
Open
+34
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbyx
force-pushed
the
libc-test-windows-port
branch
from
d4e8842 to
5771cf0
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
4 times, most recently
from
809ef9f to
0306748
Compare
|
|
mbyx
force-pushed
the
libc-test-windows-port
branch
3 times, most recently
from
1692d40 to
9428748
Compare
3 tasks
mbyx
force-pushed
the
libc-test-windows-port
branch
8 times, most recently
from
ab9e478 to
3dbb7a5
Compare
tgross35
reviewed
Aug 10, 2025
mbyx
force-pushed
the
libc-test-windows-port
branch
3 times, most recently
from
89bbc29 to
3dcc655
Compare
mbyx
force-pushed
the
libc-test-windows-port
branch
from
3dcc655 to
8f770d3
Compare
tgross35
reviewed
Aug 12, 2025
There was a problem hiding this comment.
I didn't mean to delete all of the original ctest right now :), only that you can swap a target from ctest to ctest-next rather than running both for that specific target
tgross35
reviewed
Aug 12, 2025
Comment on lines
+840
to
+843
| // Windows uppercase structs don't have `struct` in fr.into()ont: | ||
| t if ty.chars().next().unwrap().is_uppercase() => t.to_string().into(), | ||
| "stat" => "struct __stat64".to_string().into(), | ||
| "utimbuf" => "struct __utimbuf64".to_string().into(), |
There was a problem hiding this comment.
What's the difference with original ctest here?
| _ => None, | ||
| } | ||
| }); | ||
| cfg.rename_type(move |ty| { |
There was a problem hiding this comment.
In ctest we should rename this function rename_alias or rename_type_alias, I was thinking it handled all types for a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for testing the windows platform using
ctest-nextas well as the originalctest. A minor bug was also fixed along the way, where we have some public primitive types that aren't available in C (this can be fixed with skips instead as well).Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI