Skip to content

Enable strftime, mkostemp[s] on Redox #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuamegnauth54
Copy link

@joshuamegnauth54 joshuamegnauth54 commented Aug 10, 2025

Description

I exported a few functions that Redox's relibc supports (see the sources section). Nothing fancy.

Sources

Here are links to where the functions are implemented in relibc:

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

Redox's relibc supports:
* mkostemp
* mkostemps
* strftime
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for providing links. Any reason it's marked as a draft?

@joshuamegnauth54
Copy link
Author

I wanted to get confirmation from someone from Redox first. Also, I didn't run the tests yet due to a busy day (I hope to run them soon though!).

@tgross35
Copy link
Contributor

Makes sense, cc @jackpot51 for the redox portion.

Copy link
Contributor

@jackpot51 jackpot51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants