Enable strftime, mkostemp[s] on Redox#4629
Merged
tgross35 merged 1 commit intorust-lang:mainfrom Aug 13, 2025
Merged
Conversation
Redox's relibc supports: * mkostemp * mkostemps * strftime
joshuamegnauth54
force-pushed
the
missing-redox-fns
branch
from
d0a72bc to
f3b852f
Compare
tgross35
approved these changes
Aug 11, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
This LGTM, thanks for providing links. Any reason it's marked as a draft?
Contributor
Author
|
I wanted to get confirmation from someone from Redox first. Also, I didn't run the tests yet due to a busy day (I hope to run them soon though!). |
Contributor
|
Makes sense, cc @jackpot51 for the redox portion. |
Contributor
|
Thanks for the PR, and for the review! |
tgross35
added
the
stable-nominated
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 19, 2025
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 19, 2025
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Sep 19, 2025
Redox's relibc supports: * mkostemp * mkostemps * strftime (backport <rust-lang#4629>) (cherry picked from commit 8380bad)
Merged
tgross35
added
stable-applied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I exported a few functions that Redox's
relibcsupports (see the sources section). Nothing fancy.Sources
Here are links to where the functions are implemented in
relibc:Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI