Skip to content

triagebot.toml: Fix src/new/linux_uapi path #4635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025

Conversation

neuschaefer
Copy link
Contributor

Commit 3356f12 ("Begin source reorganization with linux/can.h") introduced a new directory structure for reorganizing the source code. It is called src/new/ everywhere but in triagebot.toml, likely because src/reorg/ is an older name used during development.

cc @tgross35

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 enabled auto-merge August 11, 2025 07:59
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Aug 11, 2025
@tgross35
Copy link
Contributor

For reference, we'd eventually like to have things in new structured more like the headers they came from, rather than the current split by architecture. But that's going to take a long time, I've only done one module so far.

@neuschaefer
Copy link
Contributor Author

@tgross35 is there a design document for the new structure? At a cursory glance I didn't find one

@tgross35
Copy link
Contributor

tgross35 commented Aug 11, 2025

Definitely not :) We just loosely agreed that we would like a better structure, needs some experimentation to figure out exactly what that is. But basically I've been thinking the top-level modules would map to various repos/sources (glibc, musl, uapi, etc), then modules would be used to match their directory structure. It would be nice to reuse some code too, how to do that is the trickiest part (maybe top-level modules like linux_common, then e.g. glibc::pthread can pub use crate::linux_common::stat?)

No idea what's up with CI here, there was a recent release so it may just be having cache problems.

Commit 3356f12 ("Begin source reorganization with `linux/can.h`")
introduced a new directory structure for reorganizing the source code.
It is called `src/new/` everywhere but in triagebot.toml, likely because
`src/reorg/` is an older name used during development.
@tgross35 tgross35 added this pull request to the merge queue Aug 11, 2025
Merged via the queue into rust-lang:main with commit 627a530 Aug 11, 2025
50 of 52 checks passed
@neuschaefer neuschaefer deleted the reorg branch August 11, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable-nominated This PR should be considered for cherry-pick to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants