Skip to content

[0.2] Raise libc's FreeBSD ABI to 12 #4688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2025
+3 −5
Merged

[0.2] Raise libc's FreeBSD ABI to 12 #4688

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e97d07a
Raise libc's FreeBSD ABI to 12
asomers Sep 17, 2021
f1fe193
build.rs: Avoid duplicate branch in FreeBSD version handling
joshtriplett Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ fn main() {
let target_arch = env::var("CARGO_CFG_TARGET_ARCH").unwrap_or_default();

// The ABI of libc used by std is backward compatible with FreeBSD 12.
// The ABI of libc from crates.io is backward compatible with FreeBSD 11.
// The ABI of libc from crates.io is backward compatible with FreeBSD 12.
//
// On CI, we detect the actual FreeBSD version and match its ABI exactly,
// running tests to ensure that the ABI is correct.
Expand All @@ -69,11 +69,9 @@ fn main() {
println!("cargo:warning=setting FreeBSD version to {vers}");
vers
} else if libc_ci {
which_freebsd().unwrap_or(11)
} else if rustc_dep_of_std {
12
which_freebsd().unwrap_or(12)
} else {
11
12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the last two branches of the if identical, which is causing it to fail checks in CI.

};

match which_freebsd {
Expand Down
Loading