Skip to content

Update Ubuntu to 25.10 #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Update Ubuntu to 25.10 #4698

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6a03c98
Change all dockerfiles to use Ubuntu 25.10 because 24.10 is EOL and a…
joshtriplett Sep 16, 2025
29ef11d
patch sources
tgross35 Sep 18, 2025
26070be
fix sed
tgross35 Sep 18, 2025
90e00de
debugging
tgross35 Sep 18, 2025
ee90db4
change sed
tgross35 Sep 18, 2025
55850d7
do not merge: disable `needs`
tgross35 Sep 18, 2025
389eaf7
cleanup
tgross35 Sep 18, 2025
c110d84
try without replacement
tgross35 Sep 18, 2025
68cd67e
remove openbios
tgross35 Sep 18, 2025
56c17f2
Treat MS_NOUSER as unsigned
tgross35 Sep 18, 2025
d8d039a
skip baud tests
tgross35 Sep 19, 2025
43ee830
Resolve `clippy::zero_ptr`
tgross35 Sep 19, 2025
7596d0c
Drop libxml2
tgross35 Sep 19, 2025
0274988
do not merge: increase parallel count
tgross35 Sep 19, 2025
a7f189d
Skip basename on musl
tgross35 Sep 19, 2025
392e80a
try bumping sparc
tgross35 Sep 19, 2025
dd1004d
Revert "Skip basename on musl"
tgross35 Sep 19, 2025
96ee6bf
add musl patch
tgross35 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/unix/linux_like/linux/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2129,7 +2129,8 @@ pub const _PC_ALLOC_SIZE_MIN: c_int = 18;
pub const _PC_SYMLINK_MAX: c_int = 19;
pub const _PC_2_SYMLINKS: c_int = 20;

pub const MS_NOUSER: c_ulong = 0xffffffff80000000;
// FIXME: should this be an int? The suffix is `U` not `UL`.
pub const MS_NOUSER: c_ulong = 1 << 31;
Comment on lines -2132 to +2133
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote the glibc patch. Sorry, I didn't expect breakage here.

Here is my rational from the commit message [1]:

Using gcc -Wshift-overflow=2 -Wsystem-headers to compile a file
including <sys/mount.h> will cause a warning since 1 << 31 is undefined
behavior on platforms where int is 32-bits.

Technically unsigned integers aren't allowed in C enum types, it is a GCC extension that is widely supported. We decided it was safe to use since the extension is already required for EPOLLONESHOT and EPOLLET [2].

Regarding the FIXME, I am not super familiar with Rust, but the mount function uses unsigned long for the flags argument. Until C23 enums could not have a type other than int, otherwise UL probably would have made more sense. Hopefully that helps you a bit in your decision.

[1] https://inbox.sourceware.org/libc-alpha/[email protected]/
[2] https://inbox.sourceware.org/libc-alpha/[email protected]/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your patch makes complete sense, I assume the intent was always to be 0x80000000 rather than the sign-extended 0xffffffff80000000. I just left that fixme as something to double check after the experimentation here; surprised you found this PR out of the blue, but thank you for saving me the work :)

I wrote the glibc patch. Sorry, I didn't expect breakage here.

Not at all a problem, there's nothing user-visible—just a test failure checking the equality of constants. Expected whenever the libraries we test against get updated.


pub const _SC_ARG_MAX: c_int = 0;
pub const _SC_CHILD_MAX: c_int = 1;
Expand Down
Loading