[rust] Add CI Checks to Rust fork #186
Conversation
|
Is there precedent for using these actions in other rust-lang projects?
I see the latter is used by LLVM already, but pinned to a specific commit, which is prudent since tags can change -- and this was a recent vulnerability in a popular action, in case you missed it. |
Thanks! For the former, I would use https://github.com/rust-lang/rust/blob/master/src/ci/scripts/free-disk-space.sh. |
dianqk
force-pushed
the
ci-checks
branch
2 times, most recently
from
eee88ca to
04ebfef
Compare
- On Linux, run `check-llvm` and `check-lld`. - On macOS, run `check-llvm`.
|
As this is a read-only action in a repo that never produces any artifacts, we probably don't need to be overly concerned with GHA security? |
I suppose you're right, but it doesn't hurt to be a little cautious in case that ever changes. |
| export CC=/usr/bin/clang-18 | ||
| export CXX=/usr/bin/clang++-18 | ||
| ./.ci/monolithic-linux.sh "${projects_to_build}" "${project_check_targets}" "${runtimes_to_build}" "${runtimes_check_targets}" "${runtimes_check_targets_needs_reconfig}" |
There was a problem hiding this comment.
I think we need to move away from using monolithic-linux.sh here, because it is too tightly bound to LLVM's CI runners. This now needs sccache to be installed. It's probably more robust to just do our own cmake + ninja invocations.
check-llvmandcheck-lld.check-llvm.I haven't added it on Windows yet, as I haven't been able to get it working with the free tier of GitHub Actions.