Skip to content

Conversation

tiif
Copy link
Member

@tiif tiif commented Jun 6, 2024

@tiif
Copy link
Member Author

tiif commented Jun 6, 2024

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jun 6, 2024
@tiif tiif requested a review from oli-obk June 7, 2024 17:31
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

@oli-obk
Copy link
Contributor

oli-obk commented Jun 8, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 8, 2024

📌 Commit 2f206fa has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 8, 2024

⌛ Testing commit 2f206fa with merge c51b733...

@bors
Copy link
Contributor

bors commented Jun 8, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing c51b733 to master...

@bors bors merged commit c51b733 into rust-lang:master Jun 8, 2024
Copy link
Member

@RalfJung RalfJung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I found some comment and test nits, would be nice if you could file a follow-up PR for that. :)

bors added a commit that referenced this pull request Jun 9, 2024
Follow up PR for eventfd shim

Follow up of #3650
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Jun 9, 2024
@tiif tiif deleted the feat/eventfd branch November 5, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete and fix our eventfd implementation
5 participants