New Stacked Borrows, now with better support for interior mutability #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
new-interior-mut
branch
from
d326769 to
0b64cee
Compare
RalfJung
force-pushed
the
new-interior-mut
branch
from
0b64cee to
f4e45ff
Compare
|
The rustc PR landed, this is ready for review. |
RalfJung
force-pushed
the
new-interior-mut
branch
from
3c2faf0 to
d694dc4
Compare
oli-obk
reviewed
Nov 8, 2018
| // Check borrow and stack item for compatibility. | ||
| match (itm, bor) { | ||
| (BorStackItem::FnBarrier(_), _) => { | ||
| return Err(format!("Trying to reactivate a borrow ({:?}) that lives \ |
There was a problem hiding this comment.
This has no tests that I could find
There was a problem hiding this comment.
Barriers are not implemented yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waits on rust-lang/rust#55549 to land