Support branch promotion #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically opens an internals thread and a blog PR after promoting a stable release (if configured, and will only be configured on dev-static). Caveat: needs human user to set release notes URL and scheduled release date. That will be done via flags to start-release.py in simpleinfra, probably.
This bumps branches on rust-lang/rust and creates the cargo branch at the appropriate commit; the only missing component is the actual PR that will bump the channel (src/ci/channel) to stable and cherry pick a fresh copy of the release notes. I think it makes sense for now to leave that step to human hands: it's pretty manual (need to track down the release notes, which might or might not have merged already; need to check for last minute beta backports...). So humans likely are involved anyway, at which point it's not really a huge win for us to automate opening a PR or creating a temporary branch. This automation already avoids the annoying bits and the bits that require privileges (e.g., force pushing branches).
|
I realized I also missed the step that bumps src/ci/channel on beta, which is pretty routine. But I think we can leave that as future work; opening 1 or 2 PRs isn't a huge delta and sometimes we already have a few beta backports for that PR. |
pietroalbini
approved these changes
Jul 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps branches on rust-lang/rust and creates the cargo branch at the
appropriate commit; the only missing component is the actual PR that will bump
the channel (src/ci/channel) to stable and cherry pick a fresh copy of the
release notes. I think it makes sense for now to leave that step to human hands:
it's pretty manual (need to track down the release notes, which might or might
not have merged already; need to check for last minute beta backports...). So
humans likely are involved anyway, at which point it's not really a huge win for
us to automate opening a PR or creating a temporary branch.
This automation already avoids the annoying bits and the bits that require
privileges (e.g., force pushing branches).
Based on #45