Skip to content

Modify mutable deref rule for &mut T #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Modify mutable deref rule for &mut T #1758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
596c577
Modify mutable deref rule for `&mut T`
chorman0773 Mar 13, 2025
c732fa0
Apply suggestions from PR
chorman0773 Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/expressions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ The following expressions can be mutable place expression contexts:
* [Temporary values].
* [Fields][field]: this evaluates the subexpression in a mutable place expression context.
* [Dereferences][deref] of a `*mut T` pointer.
* Dereference of a variable, or field of a variable, with type `&mut T`.
* Dereference of a movable place, with type `&mut T`. This includes variables and their fields, as well as temporaries.
Copy link
Contributor

@traviscross traviscross Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Dereference of a movable place, with type `&mut T`. This includes variables and their fields, as well as temporaries.
* Dereference of a movable place with type `&mut T`. This includes variables and their fields, as well as temporaries.

Copy link
Contributor

@traviscross traviscross Mar 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add an internal link on "movable place" also.

Note: This is an exception to the requirement of the next rule.
* Dereferences of a type that implements `DerefMut`:
this then requires that the value being dereferenced is evaluated in a mutable place expression context.
Expand Down