Skip to content

Conversation

@iampi31415
Copy link
Contributor

@iampi31415 iampi31415 commented Jun 30, 2025

Not all expressions evaluate to a value. Examples are return, loop, break. This is described for infinite loops but not as a statement applicable to a subset of the expressions.

After some consideration and reading the authoring.md a "> [!Note]" was added instead of a standalone paragraph. It becomes more of a detail for careful readers.

The first two paragraphs are nearly identical to the original document. The only word removed from the initial paragraph is always because that's not true, and would trip some users up.

It links to the reference ! but another useful link could be std !. That would make both the text longer, and link to a page that starts with "this is unstable". So the latter was left out.

@iampi31415
Copy link
Contributor Author

iampi31415 commented Jun 30, 2025

looks like

@iampi31415 iampi31415 marked this pull request as ready for review June 30, 2025 12:04
@rustbot rustbot added the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jun 30, 2025
@iampi31415
Copy link
Contributor Author

I don't think improvements are desired, so I will simply close this. If anyone wants just use the PR, I won't contribute anymore.

@iampi31415 iampi31415 closed this Jul 2, 2025
@rustbot rustbot removed the S-waiting-on-review Status: The marked PR is awaiting review from a maintainer label Jul 2, 2025
@RalfJung
Copy link
Member

RalfJung commented Jul 2, 2025

Not sure what you are concluding that from, but you definitely cannot expect a review in 48h on any open source project.

I don't have a strong opinion on this PR either way.

@iampi31415
Copy link
Contributor Author

I've done many others. In the book, in the reference, in rust. They all take weeks. This one was closed because of that trend, not because I expect a review in 48h.

@RalfJung
Copy link
Member

RalfJung commented Jul 2, 2025

The book has a note in the README setting expectations:

Because the book is printed, and because we want to keep the online version of the book close to the print version when possible, it may take longer than you're used to for us to address your issue or pull request.

So far, we've been doing a larger revision to coincide with Rust Editions. Between those larger revisions, we will only be correcting errors. If your issue or pull request isn't strictly fixing an error, it might sit until the next time that we're working on a large revision: expect on the order of months or years. Thank you for your patience!

I acknowledge this is unusual, but it's written out explicitly to minimize surprises.

In terms of rustc PRs, rust-lang/rust#143098 didn't even take 5 days until you closed it. You got a message setting expectations when opening that PR:

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

If you expect reviews within a few days, then yeah Rust is not the right project for you to contribute to. Thank you for trying anyway! Unfortunately, we have too many contributors and too few reviewers for such fast turn-around times. Sorry to hear that our volunteers did not do their free labor as fast as you expected them to. I hope you'll find other projects that can live up to your expectations.

@iampi31415
Copy link
Contributor Author

iampi31415 commented Jul 2, 2025

I do think it's not, indeed. I'll look for other projects to exploit volunteers, thanks. Note, that it will save my free and unpaid time as well, as little as it matters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants