Update proc_macro to use the attribute template
#1887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
traviscross
force-pushed
the
proc_macro
branch
from
676a3e5 to
e49d5d9
Compare
This comment has been minimized.
This comment has been minimized.
traviscross
approved these changes
Oct 21, 2025
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This renames this section to follow the attribute template. Although I like the old title, since it describes what it does, I would prefer to not make exceptions and stay consistent.
Trying to avoid conflict with the `proc_macro` attribute rule. (Though that rule name may also change later.)
Reworded to follow the attribute template.
This is a slight rewording to clarify that the name of the function is what is inserted in the root.
To follow the attribute template rename.
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
macro.proc.proc_macro.syntaxmacro.proc.proc_macro.allowed-positionsmacro.proc.proc_macro.duplicatesRenamed rules:
macro.proc.proc_macrois nowmacro.proc.proc_macro-cratemacro.proc.proc_macro.introis nowmacro.proc.proc_macro-crate.intromacro.proc.proc_macro.token-streamis nowmacro.proc.proc_macro-crate.token-streammacro.proc.proc_macro.spanis nowmacro.proc.proc_macro-crate.spanmacro.proc.functionis nowmacro.proc.proc_macromacro.proc.function.introis nowmacro.proc.proc_macro.intromacro.proc.function.defsplit intomacro.proc.proc_macro.syntaxandmacro.proc.proc_macro.behaviormacro.proc.function.namespaceis nowmacro.proc.function.namespacemacro.proc.function.invocationis nowmacro.proc.function.invocation