Update link to use the attribute template
#1895
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
The old text was missing some keys. This adds the keys as a list, with some more explicit organization.
It was in the wrong section.
There is a warning without it.
This doesn't look like behavioral rules, but more of an explanation. Also move it to the `raw-dylib` section, since it seems mostly relevant there.
This is already specified in the raw-dylib section.
Add an example, and slight rewording.
It was in the middle of the modifiers section.
Dropping the use of "Rust compiler".
This just simplifies the wording, and links to the relevant section.
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
items.extern.attributes.link.allowed-positionsitems.extern.attributes.link.duplicatesitems.extern.attributes.link.nameitems.extern.attributes.link.name.introitems.extern.attributes.link.kinditems.extern.attributes.link.kind.introitems.extern.attributes.link.modifiers.introRemoved rules:
items.extern.attributes.link.kind-raw-dylib,items.extern.attributes.link.kind-raw-dylib.intro,items.extern.attributes.link.kind-raw-dylib.import-- moved into noteRenamed rules:
items.extern.attributes.link.dylibis nowitems.extern.attributes.link.kind.dylibitems.extern.attributes.link.staticis nowitems.extern.attributes.link.kind.staticitems.extern.attributes.link.frameworkis nowitems.extern.attributes.link.kind.frameworkitems.extern.attributes.link.raw-dylibis nowitems.extern.attributes.link.kind.raw-dylibitems.extern.attributes.link.name-requirementis nowitems.extern.attributes.link.name.requirementitems.extern.attributes.link.modifiers.multiplesplit intoitems.extern.attributes.link.modifiers.onceanditems.extern.attributes.link.modifiers.duplicatesitems.extern.attributes.link.wasm_import_modulesplit intoitems.extern.attributes.link.wasm_import_module.behavioritems.extern.attributes.link.kind-raw-dylib.platform-specificmoved intoitems.extern.attributes.link.kind.raw-dylib