Update no_implicit_prelude to use the attribute template
#1914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ehuss
force-pushed
the
no_implicit_prelude
branch
from
19a6c42 to
acd6d6d
Compare
ehuss
force-pushed
the
no_implicit_prelude
branch
from
acd6d6d to
227819e
Compare
This comment has been minimized.
This comment has been minimized.
ehuss
force-pushed
the
no_implicit_prelude
branch
from
227819e to
20c562e
Compare
This is to follow the attribute template.
This rewrites the intro to be a little more general, and moves the description of the behavior to a specific rule that can be cited.
More closely align with the template, and some minor word tweaks.
… text This follows our style guide where the main text should document the current edition, and the edition blocks should note the differences to previous editions.
One of the comments in the example stretched out a bit far; let's wrap that and reword the comments in the example for clarity and flow.
It's more clear to say either that something can be applied "at the crate level" or "to the crate" than "to the crate level". Let's pick the latter and adjust for better grammatical parallelism.
Rather than saying "or any of its descendants", we can say "and its descendants" to express the same thing more concisely. Let's do that.
The remainder of this note is in the present tense, so saying that something "will" happen starting in the 2018 edition makes it sound as though that will happen in the future, even if what we mean is that the compiler "will" do it in the 2018 edition and later. Let's use the present tense here in emphatic form to distinguish this, and let's expand "it" for clarity.
traviscross
force-pushed
the
no_implicit_prelude
branch
from
af43388 to
a5a9f03
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
traviscross
approved these changes
Nov 11, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
names.preludes.no_implicit_prelude.syntaxnames.preludes.no_implicit_prelude.allowed-positionsnames.preludes.no_implicit_prelude.duplicatesnames.preludes.no_implicit_prelude.excluded-preludes