Update non_exhaustive to use the attribute template
#1921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This adds a rule name that was missing for this statement. It also clarifies why this is being said.
This statement isn't really a rule, but more of a high-level explanation. I have moved it to the intro where I think it better belongs.
Some word cleanup and a hidden clarification.
The original felt a little awkward with how it differentiated between enum and enum variants. I also wasn't terribly happy with using a list here.
This adds a missing rule for this paragraph. It also adds a little more clarity as to what it means.
The existing rule was mixing pattern match restrictions with match arm exhaustiveness. Although very closely related, I think they deserve to be split up. This also adds a little clarity about tuple matching.
`type` is a keyword and can't be used here.
Single-segment identifiers are bindings and don't work to match against a Unit struct.
The intent here is to highlight exactly where the errors are in the example (and which ones aren't errors!).
ehuss
force-pushed
the
non_exhaustive
branch
from
f468b0c to
d086375
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.type-system.non_exhaustive.duplicatesattributes.type-system.non_exhaustive.enum-exhaustivenessattributes.type-system.non_exhaustive.enum-castattributes.type-system.non_exhaustive.inhabitedRenamed rules:
attributes.type-system.non_exhaustive.external-cratemoved to.introbecause it is generally explaining the purpose.