Skip to content

Document promotion of match scrutinees #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Document promotion of match scrutinees #1963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/expressions/match-expr.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,26 @@ r[expr.match.guard.value]
Only when the guard evaluates to true is the value moved, or copied, from the scrutinee into the variable.
This allows shared borrows to be used inside guards without moving out of the scrutinee in case guard fails to match.

> [!NOTE]
> Due to this, the scrutinee may undergo [constant promotion], even if later moved.
>
> ```rust
> struct S;
> let _y: &'static S;
> match S {
> // ^ 1. The scrutinee is evaluated into a temporary place and
> // a shared borrow is taken, causing promotion.
> //
> x if { _y = &x; true } => {}
> // ^ ^^^^^^^ 2. This references the promoted value.
> // |
> // 3. The move into `x` happens after the value has been promoted.
> _ => (),
> }
> ```
>
> See [issue #145237](https://github.com/rust-lang/rust/issues/145237) for more details.

r[expr.match.guard.no-mutation]
Moreover, by holding a shared reference while evaluating the guard, mutation inside guards is also prevented.

Expand All @@ -163,6 +183,7 @@ r[expr.match.attributes.inner]
[`cfg`]: ../conditional-compilation.md
[attributes on block expressions]: block-expr.md#attributes-on-block-expressions
[binding mode]: ../patterns.md#binding-modes
[constant promotion]: destructors.scope.const-promotion
[Inner attributes]: ../attributes.md
[lint check attributes]: ../attributes/diagnostics.md#lint-check-attributes
[pattern]: ../patterns.md
Expand Down