Clarify struct pattern binding shorthand #2054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing text was slightly confusing with the way it worded "ref and/or mut", and wasn't quite clear what it was referring to. I pulled that out into a separate sentence. This also adds a sentence to make it very clear that this is a shorthand. This is somewhat a duplicate of patterns.destructure.named-field-shorthand, but it seems fine to me to have that. This also reworks the example. The current example didn't fit this section at all, and it's not entirely clear to me what the original intention was here. Maybe that was intended for the destructuring section? Either way, I just made this example fit this rule.
rustbot
added
the
S-waiting-on-review
traviscross
approved these changes
Oct 16, 2025
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing text was slightly confusing with the way it worded "ref and/or mut", and wasn't quite clear what it was referring to. I pulled that out into a separate sentence. This also adds a sentence to make it very clear that this is a shorthand.
This is somewhat a duplicate of
patterns.destructure.named-field-shorthand, but it seems fine to me to have that.
This also reworks the example. The current example didn't fit this section at all, and it's not entirely clear to me what the original intention was here. Maybe that was intended for the destructuring section? Either way, I just made this example fit this rule.