Skip to content

Use doc, not test for fn item inner attr example #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Use doc, not test for fn item inner attr example #906

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7488558
Use `doc`, not `test` for fn item inner attr example
Havvy Nov 21, 2020
645a7b1
Address review comments
Havvy Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/items/functions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ available while running tests.

```rust
fn test_only() {
#![test]
#![doc("Example")]
Copy link
Contributor

@petrochenkov petrochenkov Nov 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#![doc("Example")]
#![doc = "Example"]

doc("Example") is not currently rejected by validation, but it doesn't do anything.

}
```

Expand Down