Skip to content

Conversation

fbryden
Copy link

@fbryden fbryden commented Nov 13, 2024

No description provided.

@BurntSushi
Copy link
Member

A change like this without literally any accompanying explanation or benchmarks isn't really appropriate. The obvious downside of this change is that it increases memory usage across the board. In particular, that CacheLine is problematic since it takes up 64 bytes on its own. So this change increases base memory usage from 8 * 64 = 512 bytes to 32 * 64 = 2,048 bytes.

@fbryden
Copy link
Author

fbryden commented Nov 13, 2024

@BurntSushi I am so so sorry, I did not mean to open this pull request against the original repo - it was only meant for my fork. I completely understand (and agree) this change is not appropriate across the board!

@fbryden fbryden closed this Nov 13, 2024
@BurntSushi
Copy link
Member

Ah no worries, understood.

(I might be open to making this a runtime configurable parameter. If you want to file an issue about it.)

@fbryden
Copy link
Author

fbryden commented Nov 13, 2024

Thank you so much!
I've filed #1241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants