Reduce crate size by excluding fuzz/ and record/ #1281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fuzz/ and record/ directories are about 2MiB, and are not used by the end user. This removes them from the crate for future publishes. Also, this avoids risk of an [xz-style attack] leveraging the binary files produced by fuzzing, where malicious code could be slipped in past review through binary test data. [zx-style attack]: https://en.wikipedia.org/wiki/XZ_Utils_backdoor
erickt
added a commit
to erickt/regex
that referenced
this pull request
Aug 25, 2025
I missed more binary test data `tests/fuzz/` in rust-lang#1281, which should remove another 56KiB from the regex crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fuzz/ and record/ directories are about 2MiB, and are not used by the end user. This removes them from the crate for future publishes.
Also, this avoids risk of an xz-style attack leveraging the binary files produced by fuzzing, where malicious code could be slipped in past review through binary test data.