Skip to content

MaybeDangling #3336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 20, 2024
+268 −0
Merged

MaybeDangling #3336

Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f0b49f0
add maybe-dangling RFC
RalfJung Oct 29, 2022
d28f052
fix markdown quirks
RalfJung Oct 31, 2022
baf3d9c
to Deref or not to Deref
RalfJung Oct 31, 2022
c147c8a
rebase the reference diff
RalfJung Oct 31, 2022
982b51d
trait interaction
RalfJung Nov 2, 2022
3c7735a
fix typo
RalfJung Nov 4, 2022
f1064b0
fix typo
RalfJung Nov 6, 2022
53d8d84
clarification
RalfJung Jan 2, 2023
481f2ca
add some real-world examples
RalfJung Jul 19, 2023
f5c12b3
add comparison with some related types
RalfJung Aug 1, 2023
4d23931
attempts at clarification
RalfJung Aug 24, 2023
8f5f5bf
fix syntax error
RalfJung Aug 28, 2023
2077313
add possible alternative: attribute instead of type
RalfJung Sep 12, 2023
572f23b
fix wording
RalfJung Sep 27, 2023
c5a4988
future possibility: attribute / Box magic
RalfJung Sep 29, 2023
64bf786
mention the maybe-dangling crate
RalfJung Dec 7, 2023
d6bfbe7
UnsafeAliased -> UnsafePinned
RalfJung Apr 30, 2024
be7581c
set RFC number
RalfJung May 9, 2024
ee08c28
Cleanup trailing whitespace
traviscross May 20, 2024
d04f509
Prepare RFC 3336 to be merged
traviscross May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions text/3336-maybe-dangling.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
- Feature Name: `maybe_dangling`
- Start Date: 2022-09-30
- RFC PR: [rust-lang/rfcs#3336](https://github.com/rust-lang/rfcs/pull/3336)
- Rust Issue: [rust-lang/rust#0000](https://github.com/rust-lang/rust/issues/0000)
- Tracking Issue: [rust-lang/rust#118166](https://github.com/rust-lang/rust/issues/118166)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about also fixing the template which currently still reads "Rust Issue:" here


# Summary
[summary]: #summary
Expand Down Expand Up @@ -106,8 +106,8 @@ the dangling `Box` was passed inside a `ManuallyDrop`, so there is no UB.

The 2nd example can be fixed by passing the closure in a `MaybeDangling`:
```rust
// Argument is passed as `MaybeDangling` since we might actually keep
// it around after its lifetime ends (at which point the caller can
// Argument is passed as `MaybeDangling` since we might actually keep
// it around after its lifetime ends (at which point the caller can
// start dropping memory it points to).
fn thread(control: ..., closure: MaybeDangling<impl FnOnce() + 'lifetime>) {
closure.into_inner()();
Expand Down