Skip to content

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Oct 2, 2025

As discussed in #3865 (comment), let's add us as the reviewer team for "not-rfc" changes in this repo.

r? @jieyouxu

@rustbot

This comment has been minimized.

@Urgau Urgau force-pushed the assign-owners-internal-sites branch from cafe4fd to a6ebd74 Compare October 2, 2025 09:29
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me as the maintenance team, thanks

@jieyouxu jieyouxu added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label Oct 2, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 2, 2025

I was going to say "I wonder if we can auto-apply not-rfc label for PRs not modifying text/" (as a follow-up)... I can't remember, can label trigger files use negative path filters? If triagebot can't handle that, it's fine, not worth the impl complexity to support IMO.

@Urgau
Copy link
Member Author

Urgau commented Oct 2, 2025

can label trigger files use negative path filters?

No, that's not supported currently, but we could do the same thing as here and manually list the files and directory, it wouldn't be much.

@jieyouxu
Copy link
Member

jieyouxu commented Oct 2, 2025

but we could do the same thing as here and manually list the files and directory, it wouldn't be much

Ah the counter-example I had in mind was you could have both RFC changes and non-RFC changes in the same PR, then not-rfc would be inaccurate. But edge case IMO. Anyway, just a musing, not for this PR.

@jieyouxu jieyouxu merged commit 2566590 into rust-lang:master Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants