Skip to content

fix: Fix checking for false labelDetailsSupport value. #18388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lnicola merged 2 commits into from
Oct 23, 2024
Merged

fix: Fix checking for false labelDetailsSupport value. #18388

lnicola merged 2 commits into from
Oct 23, 2024

Conversation

@jaboatman
Copy link
Contributor

@jaboatman jaboatman commented Oct 23, 2024 •
edited
Loading

The check for labelDetailsSupport only checks for non-None, which means setting labelDetailsSupport: false incorrectly treats it as being supported.

For context: mrcjkb/rustaceanvim#414

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2024
@lnicola
Copy link
Member

lnicola commented Oct 23, 2024 •
edited
Loading

Thanks! But let's remove the as_ref and do == Some(true) like above, it's a bit tidier.

@jaboatman
Copy link
Contributor Author

jaboatman commented Oct 23, 2024

Thanks! But let's remove the as_ref and do == Some(true) like above, it's a bit tidier.

Sure, no problem. Done.

@lnicola lnicola enabled auto-merge October 23, 2024 18:23
@lnicola lnicola added this pull request to the merge queue Oct 23, 2024
Merged via the queue into rust-lang:master with commit f0f2605 Oct 23, 2024
9 checks passed
@lnicola lnicola changed the title Fix checking for false labelDetailsSupport value. fix: Fix checking for false labelDetailsSupport value. Oct 23, 2024
@Veykril Veykril mentioned this pull request Oct 23, 2024
Closed
@lnicola lnicola mentioned this pull request Oct 24, 2024
Merged
@wyuenho wyuenho mentioned this pull request Dec 7, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaboatman @lnicola @rustbot