Skip to content

internal: Pretty-print Config in status command #18394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Veykril merged 1 commit into from
Oct 24, 2024
Merged

internal: Pretty-print Config in status command #18394

Veykril merged 1 commit into from
Oct 24, 2024

Conversation

@Wilfred
Copy link
Contributor

@Wilfred Wilfred commented Oct 23, 2024 •
edited
Loading

Config can become very big, even for relatively small rust projects, and printing everything on one line makes reading the output in VS Code harder.

@Wilfred
internal: Pretty-print Config in status command
909144f 
Config can become very big, even for relatively small rust project,
and printing everything on one line makes reading the output in VS Code
harder.
@Wilfred Wilfred marked this pull request as ready for review October 23, 2024 22:20
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2024
@Veykril Veykril added this pull request to the merge queue Oct 24, 2024
@lnicola
Copy link
Member

lnicola commented Oct 24, 2024

Related, Config::default_config is huge and a bit confusing, at least when you're looking at the unformatted output. Maybe we should omit it when printing Config.

Merged via the queue into rust-lang:master with commit 3f6b0fa Oct 24, 2024
9 checks passed
@davidbarsky davidbarsky deleted the pretty_print_status branch October 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Wilfred @lnicola @Veykril @rustbot