fix: Add missing cfg flags for core crate
#18395
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some types in `core` are conditionally compiled based on `target_has_atomic` or `target_has_atomic_load_store` without an argument, for example `AtomicU64`. This is less noticeable in Cargo projects, where rust-analyzer adds the output `RUSTC_BOOTSTRAP=1 cargo rustc --print cfg` so it gets the full set of cfg flags. This fixes go-to-definition on `std::sync::atomic::AtomicU64` in non-cargo projects.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Oct 24, 2024
Member
Sounds like we should make that work for non cargo projects as well (and ideally remove the hardcoded stuff here entirely) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some types in
coreare conditionally compiled based ontarget_has_atomicortarget_has_atomic_load_storewithout an argument, for exampleAtomicU64.This is less noticeable in Cargo projects, where rust-analyzer adds the output of
RUSTC_BOOTSTRAP=1 cargo rustc --print cfgso it gets the full set of cfg flags.This fixes go-to-definition on
std::sync::atomic::AtomicU64in non-cargo projects.