internal: Do not cache the config directory path #18441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Member
Author
|
Seems like its still racing |
Veykril
force-pushed
the
lw-psyvmlotlvqn
branch
from
7033b95 to
3cf099f
Compare
Member
Author
|
Right htis approach is fishy generally, if a test runs that doesn't require the config stuff it will initialize the user dir static with the non test path, locking us out of successful tests here |
Veykril
force-pushed
the
lw-psyvmlotlvqn
branch
2 times, most recently
from
1fb0580 to
9323968
Compare
Veykril
changed the title
Veykril
force-pushed
the
lw-psyvmlotlvqn
branch
from
9323968 to
10a07a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18070