vscode: Only show status bar item in relevant files #18592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
darichey
force-pushed
the
status-bar-visibility
branch
from
750bb7c to
8c2910d
Compare
lnicola
approved these changes
Dec 3, 2024
Veykril
reviewed
Dec 3, 2024
darichey
force-pushed
the
status-bar-visibility
branch
from
8c2910d to
cf80ddd
Compare
Member
|
So this is why I couldn't find the status bar item for rust-analyzer in some cases even when rust-analyzer is busy running. This makes it harder to stop rust-analyzer when it is interfering with things. Edit: Found |
Member
|
I am honestly tempted to change the default to always, I've seen a lot of people confused by this behavior (rightfully so) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The status bar can become a bit crowded with many extensions adding status bar items. rust-analyzer can be a good citizen and hide itself unless the user is looking at relevant files.
I've set the default to show on Rust files and Cargo.toml. It could be reasonable to instead keep the current always-show behavior as the default, just giving users the option to configure it. I'm open to discussion!
This could also be a workaround for #15068.