Fix "Implement default members" to resolve IdentPat #20432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Aug 11, 2025
sgasho
added a commit
to sgasho/rust-analyzer
that referenced
this pull request
Aug 12, 2025
This comment has been minimized.
This comment has been minimized.
sgasho
force-pushed
the
fix/20215_implement_default_member_to_resolve_ident_pat
branch
from
7910a8c to
6beab21
Compare
|
Can you squash please? |
sgasho
force-pushed
the
fix/20215_implement_default_member_to_resolve_ident_pat
branch
from
6beab21 to
8ab6837
Compare
|
@ChayimFriedman2 |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #20215
Evidence
Before "Implement default members"
After
e.g. in "is_empty" method
Before this PR(: (Unbounded, ) | (, Unbounded) => true,
this PR: (std::ops::Bound::Unbounded, ) | (, std::ops::Bound::Unbounded) => true,