Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Jan 7, 2026

Big diff is mostly due to the first two commits adding some more docs, and the test outputs changing vastly from a new option wrapping

AI disclosure: Changes were made with help of opus 4.5

@ChayimFriedman2
Copy link
Contributor

In a perfect timing, the last VSCode release removed their horrible filtering, which hopefully should allow this to work as well in VSCode!

@Veykril
Copy link
Member Author

Veykril commented Jan 9, 2026

That only changes it to accept # and * I think though, they didn't actually address the root issue they just vibe coded the fix to my issue on the vscode issue tracker calling out those two symbols I think 😅

@ChayimFriedman2
Copy link
Contributor

I guess we can get : special-cased as well then?

@Veykril
Copy link
Member Author

Veykril commented Jan 9, 2026

Maybe

@Veykril Veykril marked this pull request as ready for review January 10, 2026 09:27
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
@Veykril Veykril added this pull request to the merge queue Jan 10, 2026
Merged via the queue into rust-lang:master with commit 2538fdb Jan 10, 2026
15 checks passed
@Veykril Veykril deleted the push-qusurvyqwmxt branch January 10, 2026 11:10
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2026
Veykril added a commit to zed-industries/zed that referenced this pull request Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants