Support more runnable kinds in project JSON #21424
Open
+115
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
I'm about to complete the match statement here with more of the same. Once you write the exact same code 5 times, it's time for a helper function.
Allows project JSON users to run a whole module of tests, benchmarks, doctests.
cormacrelf
force-pushed
the
support-more-runnable-kinds
branch
from
e77a267 to
7657739
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for benchmarks, whole modules of tests, doctests.
Fixes #20359 but you will have to update your tooling that generates the JSON to include such runnables, e.g.
testMod,doctestOne,benchOne.TODO