Skip to content

Clean unused CI features #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Clean unused CI features #3035

merged 2 commits into from
Dec 4, 2024

Conversation

pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Dec 4, 2024

No description provided.

@pvdrz pvdrz requested a review from emilio December 4, 2024 21:53
@pvdrz pvdrz force-pushed the pvdrz/ci-clean-up branch from c5e8e8f to 10c1fe5 Compare December 4, 2024 22:13
Copy link
Contributor

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the reason why we had the extra_assert stuff is really that those assertion take time (they walk over all the maps, do tons of extra hashmap lookups, etc).

When bindgen runs as a build tool in debug mode, making it slower than it already is (building in unoptimized mode etc) is pretty unfortunate...

I think I'd rather keep it, but I guess I could be convinced otherwise? At least some profiling would be useful

@pvdrz
Copy link
Contributor Author

pvdrz commented Dec 4, 2024

So the reason why we had the extra_assert stuff is really that those assertion take time (they walk over all the maps, do tons of extra hashmap lookups, etc).

When bindgen runs as a build tool in debug mode, making it slower than it already is (building in unoptimized mode etc) is pretty unfortunate...

I think I'd rather keep it, but I guess I could be convinced otherwise? At least some profiling would be useful

Hmm that's a good point. I think I'm going to revert that part

@pvdrz pvdrz force-pushed the pvdrz/ci-clean-up branch from 10c1fe5 to 98163df Compare December 4, 2024 22:17
@pvdrz pvdrz requested a review from emilio December 4, 2024 22:25
@pvdrz pvdrz closed this Dec 4, 2024
@pvdrz pvdrz reopened this Dec 4, 2024
@pvdrz pvdrz added this pull request to the merge queue Dec 4, 2024
Merged via the queue into main with commit 2da868d Dec 4, 2024
57 checks passed
@pvdrz pvdrz deleted the pvdrz/ci-clean-up branch December 9, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants