minor cleanups

Author: y21

clippy_lints/src/missing_fields_in_debug.rs

@@ -88,10 +88,7 @@ const HELP_FIELD_REFERENCE: &str = "the field referenced by this binding is unus
 const HELP_INCLUDE_ALL_FIELDS: &str = "consider including all fields in this `Debug` impl";
 const HELP_FINISH_NON_EXHAUSTIVE: &str = "consider calling `.finish_non_exhaustive()` if you intend to ignore fields";
 
-fn report_lints<I>(cx: &LateContext<'_>, span: Span, span_notes: I)
-where
-    I: Iterator<Item = (Span, &'static str)>,
-{
+fn report_lints(cx: &LateContext<'_>, span: Span, span_notes: Vec<(Span, &'static str)>) {
     span_lint_and_then(cx, MISSING_FIELDS_IN_DEBUG, span, WARN, |diag| {
         for (span, note) in span_notes {
             diag.span_note(span, note);
@@ -177,7 +174,7 @@ fn check_struct<'tcx>(
         .collect::<Vec<_>>();
 
     if !span_notes.is_empty() {
-        report_lints(cx, item.span, span_notes.into_iter());
+        report_lints(cx, item.span, span_notes);
     }
 }
 
@@ -250,7 +247,7 @@ fn check_enum<'tcx>(
     }
 
     if !span_notes.is_empty() {
-        report_lints(cx, item.span, span_notes.into_iter());
+        report_lints(cx, item.span, span_notes);
     }
 }