[read_line_without_trim]: detect string literal comparison and .ends_with() calls
#11136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #11095) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @dswij |
y21
force-pushed
the
enhance_read_line_without_trim
branch
from
ea4fc58 to
f94b066
Compare
|
wow, this PR is ancient :D (The first commit is the actual relevant addition, the second one moves some things around which causes the diff to look a bit annoying, so it's probably better reviewed commit-by-commit) |
|
☔ The latest upstream changes (presumably #12306) made this pull request unmergeable. Please resolve the merge conflicts. |
dswij
approved these changes
Feb 26, 2024
y21
force-pushed
the
enhance_read_line_without_trim
branch
from
f94b066 to
fd85db3
Compare
dswij
approved these changes
Feb 27, 2024
|
@bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint now also realizes that a comparison like
s == "foo"and calls such ass.ends_with("foo")will fail ifswas initialized by a call toStdin::read_line(because of the trailing newline).changelog: [
read_line_without_trim]: detect string literal comparison and.ends_with()callsr? @giraffate assigning you because you reviewed #10970 that added this lint, so this is kinda a followup PR ^^