Skip to content

Conversation

Jarcho
Copy link
Contributor

@Jarcho Jarcho commented Jul 7, 2024

This can wait till after #12971. I'm fine with dealing with the merge.


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 7, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 7, 2024
@llogiq
Copy link
Contributor

llogiq commented Jul 7, 2024

There are dogfood errors. Otherwise this looks ok.

@Jarcho Jarcho force-pushed the empty_brackets branch 3 times, most recently from 9180092 to 787fef0 Compare July 7, 2024 16:22
@llogiq
Copy link
Contributor

llogiq commented Jul 17, 2024

Ok, r=me once #12971 landed and this is rebased.

@bors delegate+

@bors
Copy link
Contributor

bors commented Jul 17, 2024

✌️ @Jarcho, you can now approve this pull request!

If @llogiq told you to "r=me" after making some further change, please make that change, then do @bors r=@llogiq

@rustbot

This comment has been minimized.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
@y21
Copy link
Member

y21 commented May 17, 2025

#12971 has landed so this should be unblocked now

@Jarcho
Copy link
Contributor Author

Jarcho commented May 17, 2025

Thank you for the reminder. Totally forgot about this.

Copy link

github-actions bot commented Jul 21, 2025

Lintcheck changes for 13458f9

Lint Added Removed Changed
clippy::empty_enum_variants_with_brackets 0 1 0
clippy::empty_structs_with_brackets 0 0 23

This comment will be updated if you push new changes

@rustbot
Copy link
Collaborator

rustbot commented Sep 16, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jarcho
Copy link
Contributor Author

Jarcho commented Sep 16, 2025

Ping @llogiq. I'm pretty sure the implementation has changed since you last reviewed this.

@Jarcho Jarcho added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Sep 16, 2025
* Merge code paths for struct and variants
* Adjust the span to not include leading whitespace
* Don't lint in macros
* Add proc macro detection
* Don't lint if there're comments inside the brackets.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants