-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Rework empty_with_brackets
#13063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Rework empty_with_brackets
#13063
Conversation
There are dogfood errors. Otherwise this looks ok. |
9180092
to
787fef0
Compare
This comment has been minimized.
This comment has been minimized.
#12971 has landed so this should be unblocked now |
Thank you for the reminder. Totally forgot about this. |
Lintcheck changes for 13458f9
This comment will be updated if you push new changes |
f0ed479
to
b976bea
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Ping @llogiq. I'm pretty sure the implementation has changed since you last reviewed this. |
* Merge code paths for struct and variants * Adjust the span to not include leading whitespace * Don't lint in macros * Add proc macro detection * Don't lint if there're comments inside the brackets.
b976bea
to
13458f9
Compare
This can wait till after #12971. I'm fine with dealing with the merge.
changelog: none