Skip to content

Conversation

RGafiyatullin
Copy link

@RGafiyatullin RGafiyatullin commented Sep 3, 2024


Adding a lint that checks for not using the return values from Iterator::any or Iterator::all.

changelog: added a new lint — [unused_any_all]

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 3, 2024
@nyurik
Copy link
Contributor

nyurik commented Sep 4, 2024

isn't this what #[must_use] is for?

@RGafiyatullin
Copy link
Author

@nyurik true.

For some reason I thought it would only work when put over a type, not over a method.
I should probably go and try proposing having this attribute over these methods of the Iterator trait.

Sorry for distracting you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants