Skip to content

Conversation

@samueltardieu
Copy link
Member

changelog: none

I was waiting for #13452 to be merged before sending this one. std is used instead of core when appropriate in messages.

@rustbot
Copy link
Collaborator

rustbot commented Sep 24, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 24, 2024
@samueltardieu
Copy link
Member Author

r? @Centri3
(since you dealt with #13452)

@rustbot rustbot assigned Centri3 and unassigned llogiq Oct 2, 2024
@samueltardieu
Copy link
Member Author

r?

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@samueltardieu
Copy link
Member Author

r? @xFrednet

@rustbot rustbot assigned xFrednet and unassigned Centri3 Oct 12, 2024
Copy link
Contributor

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment, otherwise looks good to me :D

@xFrednet
Copy link
Contributor

Looks good to me, thank you :D


std is red,
Core is blue,
We get purple,
if we mix the two

I actually really like this one :D

@bors
Copy link
Contributor

bors commented Oct 14, 2024

📌 Commit 46a0770 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 14, 2024

⌛ Testing commit 46a0770 with merge f444012...

@bors
Copy link
Contributor

bors commented Oct 14, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing f444012 to master...

@bors bors merged commit f444012 into rust-lang:master Oct 14, 2024
8 checks passed
@samueltardieu samueltardieu deleted the push-ymnkzlqloptz branch January 6, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants