Skip to content

Conversation

@xFrednet
Copy link
Contributor

@xFrednet xFrednet commented Oct 15, 2024

@xFrednet xFrednet added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2024
@xFrednet xFrednet assigned xFrednet and unassigned Jarcho Oct 15, 2024
@xFrednet
Copy link
Contributor Author

I'll "Roses are approved" this directly according to Zulip


Roses red approved,
Violets are moved,
Lints are allowed,
Fixes will be made

@bors
Copy link
Contributor

bors commented Oct 15, 2024

📌 Commit fcf4646 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 15, 2024

⌛ Testing commit fcf4646 with merge 7ce1eea...

@bors
Copy link
Contributor

bors commented Oct 15, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing 7ce1eea to master...

@bors bors merged commit 7ce1eea into rust-lang:master Oct 15, 2024
8 checks passed
@flip1995
Copy link
Member

This is already in stable, beta and master branch in the Rust repo. I also remember to do a last minute backport last release to stable and beta in the Rust repo. So this was already done before and I think you even included it in the changelog. So ✔️

@flip1995 flip1995 removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants