Skip to content

Conversation

@xFrednet
Copy link
Contributor

@xFrednet xFrednet commented Nov 22, 2024

This is in honor of @bors who is no longer used in this repo. I've been saving this poem for a special PR, but it just seems fitting to use it now:

Bors the bot,
Handsome and strong!
Will you go with me,
To prom?


The cat of this release is Abu nominated by @jdonszelmann :

The cats of this Clippy release

Cats for the next release can be nominated in the comments :D


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 22, 2024
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Nov 22, 2024

hi Abu! :3

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just a NIT.

Co-authored-by: Philipp Krones <[email protected]>
@blyxyas
Copy link
Member

blyxyas commented Nov 27, 2024

Speaking of that, we should totally organize the cat vote for 1.84. I think that the community has refreshed from the last cat vote we did. What does the cat council think?

@jdonszelmann
Copy link
Contributor

Oh do you need an extra cat? one sec lemme get lizzy

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Nov 27, 2024

lizzy2

@jdonszelmann
Copy link
Contributor

on the heated bathroom floor, of course...

@xFrednet xFrednet added this pull request to the merge queue Nov 28, 2024
@xFrednet
Copy link
Contributor Author

The big question is if we get enough cats to have a proper vote. If so, go ahead, cat pics are always nice!

Merged via the queue into rust-lang:master with commit 5dc5842 Nov 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants