Skip to content

Conversation

@Kampfkarren
Copy link
Contributor

Remove the documentation incorrectly saying there is no default, followed by the default.

image

changelog: [trivially_copy_pass_by_ref]: Removed incorrect documentation suggesting the default has no limit.

@rustbot
Copy link
Collaborator

rustbot commented Nov 22, 2024

r? @xFrednet

rustbot has assigned @xFrednet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 22, 2024
Copy link
Contributor

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This looks good to me, thank you!


Roses are red,
Violets are blue,
Defaults are set,
with correct doc now.

@xFrednet
Copy link
Contributor

Small thing before we can merge this, the CI fails, could you run cargo bless --test config-metadata and commit the changes? That will copy the update into Clippy's book

@xFrednet xFrednet added this pull request to the merge queue Nov 25, 2024
Merged via the queue into rust-lang:master with commit d070402 Nov 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants