Skip to content

Do not merge: check if we sometimes fail to get snippets #13941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Draft

Do not merge: check if we sometimes fail to get snippets #13941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion clippy_utils/src/source.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -573,8 +573,13 @@ fn snippet_with_applicability_sess<'a>(
}

/// Converts a span to a code snippet. Returns `None` if not available.
#[allow(clippy::unnecessary_wraps)]
pub fn snippet_opt(sess: &impl HasSession, span: Span) -> Option<String> {
sess.sess().source_map().span_to_snippet(span).ok()
// Experiment: fail loudly if the snippet cannot be obtained
match sess.sess().source_map().span_to_snippet(span) {
Ok(v) => Some(v),
Err(e) => panic!("Error when getting snippet for {span:?}: {e:?}"),
}
}

/// Converts a span (from a block) to a code snippet if available, otherwise use default.
Expand Down