New lint: always_true_conditions #14434

Dominic-Moser · 2025-03-18T20:43:47Z

This lint closes #1593

This is my first lint, please let me know if I messed something up anywhere!

changelog: [always_true_conditions]: add new lint

rustbot · 2025-03-18T20:43:52Z

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

samueltardieu · 2025-03-19T21:18:43Z

The lintcheck results shows 64 hits, which seem to be all false positives.

samueltardieu · 2025-04-06T10:20:48Z

@Dominic-Moser Do you plan to continue working on this lint?
@rustbot author

rustbot · 2025-04-06T10:20:52Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Dominic-Moser · 2025-04-08T19:44:57Z

@rustbot ready, sorry school's been hitting hard

Dominic-Moser · 2025-04-08T19:54:28Z

never mind, I have to to checks to make sure the same variable is being used throughout the whole expression

Dominic-Moser · 2025-04-18T00:26:21Z

@samueltardieu I am so confused right now, I keep trying to rebase and it keeps saying I need to rebase. I am sure this is my fault but i have no clue how to fix this...
On the bright side I do actually think that the code works properly now 🫠

Alexendoo · 2025-04-20T17:33:55Z

Your first commit contains a lot of unrelated changes 9ce8566

What I would do is first reset your branch to the current state of master

git fetch upstream
git reset --hard upstream/master

Then grab the main parts of the PR - the lint and the test file

git checkout b55d82f89c1b29f25044aeaafbbdb7a241c82c3b -- clippy_lints/src/always_true_conditions.rs tests/ui/always_true_conditions.rs

Now you can run cargo dev update_lints, add the lint registration to clippy_lints/src/lib.rs again, and make sure tests pass. Then you can create the commit once more

Dominic-Moser · 2025-05-03T02:39:49Z

@rustbot ready

This lint aims to flag a common mistake where a variable is compared against two primitives using a != operator and mistakenly linked with the || with always evaluate to true. ex. ```a != 1 || a != 2``` This helps flag a common mistake and maintain overall quality of code. changelog: new lint

rustbot · 2025-10-18T08:38:12Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

This lint aims to flag a common mistake where a variable is compared against two primitives using a != operator and mistakenly linked with the || with always evaluate to true. ex. ```a != 1 || a != 2``` This helps flag a common mistake and maintain overall quality of code. changelog: new lint

rustbot assigned Alexendoo Mar 18, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 18, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 8, 2025