Skip to content

Conversation

@devodev
Copy link

@devodev devodev commented Jun 22, 2025

Add a new restriction lint shadow_type_generic that checks for generic parameters that shadow types in scope.

Closes: #380

changelog: [shadow_type_generic]: new lint

Summary Notes

Managed by @rustbot—see help for details

@devodev devodev force-pushed the pr/devodev/new-lint-shadow-type-generic branch from 69325c4 to cf09da7 Compare June 22, 2025 23:25
@devodev devodev marked this pull request as ready for review June 23, 2025 00:24
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 23, 2025
@dswij
Copy link
Member

dswij commented Jun 28, 2025

r? clippy

@rustbot rustbot assigned flip1995 and unassigned dswij Jun 28, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Jun 29, 2025

Dear contributor. Clippy has entered a feature freeze period and will not be integrating new lints for a few weeks. You can rest assured that the Clippy team will review and discuss your proposal at the end of the feature freeze period.

If you wish to contribute to Clippy in the meantime, do not hesitate to read the pinned tracking issue about the feature freeze itself.

@rustbot label +A-lint +S-blocked -S-waiting-on-review
@rustbot note "Feature freeze"

@rustbot rustbot added A-lint Area: New lints S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Jun 29, 2025
@rustbot

This comment has been minimized.

@samueltardieu samueltardieu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Sep 17, 2025
@devodev devodev force-pushed the pr/devodev/new-lint-shadow-type-generic branch from cf09da7 to b52802f Compare November 1, 2025 14:58
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

Add a new restriction lint `shadow_type_generic` that checks for
generic parameters that shadow types in scope.

Signed-off-by: Alexandre Barone <[email protected]>
@devodev devodev force-pushed the pr/devodev/new-lint-shadow-type-generic branch from b52802f to 480ae1c Compare November 2, 2025 13:31
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@flip1995
Copy link
Member

flip1995 commented Nov 3, 2025

r? clippy

I just saw that this PR is active again. Re-assigning, as I don't have review capacity at the moment. (I wonder why r? clippy picks me for reviews in the first place, as I'm not in the general rotation, only for some specific files 🤔 )

@rustbot rustbot assigned Alexendoo and unassigned flip1995 Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-lint Area: New lints needs-fcp S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shadowing of types via Generic Parameter

6 participants