Skip to content

Fix never_loop forget to remove break in nested loop #15356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

Fix never_loop forget to remove break in nested loop #15356

merged 1 commit into from
Sep 5, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jul 27, 2025 •
edited
Loading

Closes #15350

Follow up of #15064

changelog: [never_loop] add to remove break in nested loop

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 27, 2025
@profetia
Copy link
Contributor Author

r? clippy

@rustbot rustbot assigned blyxyas and unassigned y21 Aug 11, 2025
blyxyas
blyxyas requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, just some more testing (and maybe some reasoning as to why only adding one span is valid?) would be greatly appreciated!! =^w^=

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 20, 2025
blyxyas
blyxyas requested changes Aug 24, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=^w^=

@profetia profetia requested a review from blyxyas August 24, 2025 22:35
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 24, 2025
@profetia
Copy link
Contributor Author

@blyxyas Updated. Thank you!

blyxyas
blyxyas approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

View changes since this review

@blyxyas blyxyas added this pull request to the merge queue Sep 5, 2025
Merged via the queue into rust-lang:master with commit 828ee51 Sep 5, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 5, 2025
@profetia profetia deleted the issue15350 branch September 12, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

never_loop removes label that the replaced loop was attached to (outer label)

4 participants

@profetia @rustbot @blyxyas @y21