Skip to content

feat: manual_rotate also recognize non-consts #15402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: manual_rotate also recognize non-consts #15402

wants to merge 4 commits into from
+129 −47

Conversation

ada4a
Copy link
Contributor

@ada4a ada4a commented Aug 3, 2025 •
edited by rustbot
Loading

changelog: [manual_rotate]: also recognize non-consts

fixes #13028

r? @llogiq

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 3, 2025
@samueltardieu
Copy link
Member

samueltardieu commented Aug 3, 2025 •
edited
Loading

@ada4a Note that this is a new feature, and we are in a feature freeze period, so this might be delayed.

@rustbot blocked @rustbot label +C-enhancement
@rustbot note Feature-freeze

@ada4a
Copy link
Contributor Author

ada4a commented Aug 3, 2025

The issue refers to this as a false negative, but I agree that it could be seen as a feature addition. I'm okay with waiting for a bit:)

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 23, 2025
@rust-lang rust-lang deleted a comment from rustbot Aug 23, 2025
@samueltardieu samueltardieu added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Sep 17, 2025
@rustbot

This comment has been minimized.

Sign in to view
ada4a added 3 commits October 4, 2025 21:35
@ada4a
misc: extend let-chain
8e3315f
@ada4a
extract the constant codepath
c9ee445 
switch around `*_amount` and `*_expr` -- otherwise the order gets
confusing now because of both of them being `Expr`s
@ada4a
fix: print actual consts when shifting by them
4423e05 
this is kind of a side-effect of the next commit
@rustbot
Copy link
Collaborator

rustbot commented Oct 4, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@ada4a
Copy link
Contributor Author

ada4a commented Oct 4, 2025

@rustbot note remove Feature-freeze

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@llogiq llogiq

Labels
C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False negative: manual_rotate doesn't catch variable shift amounts
4 participants
@ada4a @samueltardieu @rustbot @llogiq