Skip to content

unnecessary_operation: add space between stmts in suggestion #15432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −11
Open

unnecessary_operation: add space between stmts in suggestion #15432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion clippy_lints/src/no_effect.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,11 +305,12 @@ fn check_unnecessary_operation(cx: &LateContext<'_>, stmt: &Stmt<'_>) {
for e in reduced {
if let Some(snip) = e.span.get_source_text(cx) {
snippet.push_str(&snip);
snippet.push(';');
snippet.push_str("; ");
} else {
return;
}
}
snippet.pop(); // remove the last space
span_lint_hir_and_then(
cx,
UNNECESSARY_OPERATION,
Expand Down
10 changes: 5 additions & 5 deletions tests/ui/unnecessary_operation.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,25 +78,25 @@ fn main() {
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
5;get_number();
5; get_number();
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
5;6;get_number();
5; 6; get_number();
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
5;get_number();
5; get_number();
//~^ unnecessary_operation
42;get_number();
42; get_number();
//~^ unnecessary_operation
assert!([42, 55].len() > get_usize());
//~^ unnecessary_operation
42;get_number();
42; get_number();
//~^ unnecessary_operation
get_number();
//~^ unnecessary_operation
Expand Down
10 changes: 5 additions & 5 deletions tests/ui/unnecessary_operation.stderr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:81:5
|
LL | 5 + get_number();
| ^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5;get_number();`
| ^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5; get_number();`

error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:83:5
Expand All @@ -53,7 +53,7 @@ error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:87:5
|
LL | (5, 6, get_number());
| ^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5;6;get_number();`
| ^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5; 6; get_number();`

error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:89:5
Expand All @@ -71,13 +71,13 @@ error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:93:5
|
LL | 5..get_number();
| ^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5;get_number();`
| ^^^^^^^^^^^^^^^^ help: statement can be reduced to: `5; get_number();`

error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:95:5
|
LL | [42, get_number()];
| ^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `42;get_number();`
| ^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `42; get_number();`

error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:97:5
Expand All @@ -89,7 +89,7 @@ error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:99:5
|
LL | (42, get_number()).1;
| ^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `42;get_number();`
| ^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `42; get_number();`

error: unnecessary operation
--> tests/ui/unnecessary_operation.rs:101:5
Expand Down