-
Notifications
You must be signed in to change notification settings - Fork 1.8k
change suspicious_operation_groupings to work on the HIR instead of the AST
#15443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
No changes for 2d377f2 |
|
From what i see, it's not. I'll have to figure that out. I think it's just a case of checking whether the expression (so, |
|
Some changes occurred in clippy_lints/src/doc cc @notriddle |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@esther-ff Did you mis-rebase or something like that? |
|
Alright! Managed to fix it. |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
changelog: [
suspicious_operation_groupings]: changed the lint to work on the HIR and included a check for the existence of a suggested field.fixes #7086
As a short message, i have discovered a potential false positive, however i am not sure whether it should be part of this PR.
(I've also made a slight mistake with the last commit in this PR, i hope it doesn't affect anything. I'm a bit new to this)