Skip to content

Conversation

@esther-ff
Copy link

@esther-ff esther-ff commented Aug 8, 2025

changelog: [suspicious_operation_groupings]: changed the lint to work on the HIR and included a check for the existence of a suggested field.

fixes #7086

As a short message, i have discovered a potential false positive, however i am not sure whether it should be part of this PR.

(I've also made a slight mistake with the last commit in this PR, i hope it doesn't affect anything. I'm a bit new to this)

@rustbot
Copy link
Collaborator

rustbot commented Aug 8, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 8, 2025
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

No changes for 2d377f2

@samueltardieu
Copy link
Member

@esther-ff
Copy link
Author

esther-ff commented Aug 9, 2025

From what i see, it's not. I'll have to figure that out. I think it's just a case of checking whether the expression (so, self.coords in this case) has the suggested method? I think i can implement that soon.

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2025

Some changes occurred in clippy_lints/src/doc

cc @notriddle

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@samueltardieu
Copy link
Member

@esther-ff Did you mis-rebase or something like that?

@esther-ff
Copy link
Author

esther-ff commented Sep 21, 2025

Yeah, currently trying to fix it. Very sorry.

Alright! Managed to fix it.

@rustbot
Copy link
Collaborator

rustbot commented Sep 21, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

suspicious-operation-groupings generates a false positive, suggested code doesn't even compile

4 participants